From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTfvV-0005OX-7J for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTfvO-000112-Bf for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:04 -0400 Message-ID: <5336017D.2010301@redhat.com> Date: Sat, 29 Mar 2014 00:10:53 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-36-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-36-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 35/47] dmg: use appropriate types when reading chunks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:05, Stefan Hajnoczi wrote: > Use the right types instead of signed int: > > size_t new_size; > > This is a byte count for g_realloc() that is calculated from uint32_t > and size_t values. > > uint32_t chunk_count; > > Use the same type as s->n_chunks, which is used together with > chunk_count. > > This patch is a cleanup and does not fix bugs. > > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Kevin Wolf > --- > block/dmg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz