From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTfvz-0006jU-F4 for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTfvt-00016D-Ae for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:35 -0400 Message-ID: <53360197.7000000@redhat.com> Date: Sat, 29 Mar 2014 00:11:19 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-37-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-37-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 36/47] dmg: sanitize chunk length and sectorcount (CVE-2014-0145) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:05, Stefan Hajnoczi wrote: > Chunk length and sectorcount are used for decompression buffers as well > as the bdrv_pread() count argument. Ensure that they have reasonable > values so neither memory allocation nor conversion from uint64_t to int > will cause problems. > > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Kevin Wolf > --- > block/dmg.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Reviewed-by: Max Reitz