From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WTfwF-0007Bx-Da
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WTfw8-00019G-8D
	for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:11:51 -0400
Message-ID: <533601AB.9090101@redhat.com>
Date: Sat, 29 Mar 2014 00:11:39 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1395835569-21193-1-git-send-email-stefanha@redhat.com>
	<1395835569-21193-38-git-send-email-stefanha@redhat.com>
In-Reply-To: <1395835569-21193-38-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.0 37/47] dmg: use uint64_t
 consistently for sectors and lengths
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, pmatouse@redhat.com, qemu-stable@nongnu.org

On 26.03.2014 13:05, Stefan Hajnoczi wrote:
> The DMG metadata is stored as uint64_t, so use the same type for
> sector_num.  int was a particularly poor choice since it is only 32-bit
> and would truncate large values.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/dmg.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>