* [Qemu-devel] [PATCH RESEND] tcg/ppc64: Prepare support for Little Endian ppc64 hosts
@ 2014-03-28 16:13 Andreas Färber
2014-03-28 23:22 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2014-03-28 16:13 UTC (permalink / raw)
To: qemu-devel
Cc: Vassili Karpov (malc), qemu-ppc, Andreas Färber,
Richard Henderson
Don't hardcode TCG_TARGET_WORDS_BIGENDIAN.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
Unfortunately with this fix, execution of ./i386-softmmu/qemu-system-i386
just gets a SIGSEGV instead of the previous SIGILL on ppc64le.
This TCG breakage affects acpi-test, failing make check.
tcg/ppc64/tcg-target.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcg/ppc64/tcg-target.h b/tcg/ppc64/tcg-target.h
index 7ee50b6..51355a1 100644
--- a/tcg/ppc64/tcg-target.h
+++ b/tcg/ppc64/tcg-target.h
@@ -24,7 +24,9 @@
#ifndef TCG_TARGET_PPC64
#define TCG_TARGET_PPC64 1
+#ifndef __LITTLE_ENDIAN__
#define TCG_TARGET_WORDS_BIGENDIAN
+#endif
#define TCG_TARGET_NB_REGS 32
typedef enum {
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH RESEND] tcg/ppc64: Prepare support for Little Endian ppc64 hosts
2014-03-28 16:13 [Qemu-devel] [PATCH RESEND] tcg/ppc64: Prepare support for Little Endian ppc64 hosts Andreas Färber
@ 2014-03-28 23:22 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2014-03-28 23:22 UTC (permalink / raw)
To: Andreas Färber, qemu-devel; +Cc: qemu-ppc, Vassili Karpov (malc)
On 03/28/2014 09:13 AM, Andreas Färber wrote:
> +#ifndef __LITTLE_ENDIAN__
> #define TCG_TARGET_WORDS_BIGENDIAN
> +#endif
> #define TCG_TARGET_NB_REGS 32
>
Please let's just replace TCG_TARGET_WORDS_BIGENDIAN with HOST_WORDS_BIGENDIAN
throughout and be done with it.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-28 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-28 16:13 [Qemu-devel] [PATCH RESEND] tcg/ppc64: Prepare support for Little Endian ppc64 hosts Andreas Färber
2014-03-28 23:22 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).