From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTgMX-0004RM-AI for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTgMP-0000rm-82 for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:39:01 -0400 Message-ID: <53360803.9050100@redhat.com> Date: Sat, 29 Mar 2014 00:38:43 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-44-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-44-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 43/47] qcow2: Fix L1 allocation size in qcow2_snapshot_load_tmp() (CVE-2014-0145) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:06, Stefan Hajnoczi wrote: > From: Kevin Wolf > > For the L1 table to loaded for an internal snapshot, the code allocated > only enough memory to hold the currently active L1 table. If the > snapshot's L1 table is actually larger than the current one, this leads > to a buffer overflow. > > Signed-off-by: Kevin Wolf > --- > block/qcow2-snapshot.c | 2 +- > tests/qemu-iotests/029 | 18 +++++++++++++++++- > tests/qemu-iotests/029.out | 4 ++++ > 3 files changed, 22 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz