From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTgUH-0004nK-25 for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTgUA-0003BS-Tc for qemu-devel@nongnu.org; Fri, 28 Mar 2014 19:47:00 -0400 Message-ID: <533609E5.4000807@redhat.com> Date: Sat, 29 Mar 2014 00:46:45 +0100 From: Max Reitz MIME-Version: 1.0 References: <1395835569-21193-1-git-send-email-stefanha@redhat.com> <1395835569-21193-48-git-send-email-stefanha@redhat.com> In-Reply-To: <1395835569-21193-48-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 47/47] parallels: Sanity check for s->tracks (CVE-2014-0142) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , pmatouse@redhat.com, qemu-stable@nongnu.org On 26.03.2014 13:06, Stefan Hajnoczi wrote: > From: Kevin Wolf > > This avoids a possible division by zero. > > Convert s->tracks to unsigned as well because it feels better than > surviving just because the results of calculations with s->tracks are > converted to unsigned anyway. > > Signed-off-by: Kevin Wolf > --- > block/parallels.c | 7 ++++++- > tests/qemu-iotests/076 | 7 +++++++ > tests/qemu-iotests/076.out | 4 ++++ > 3 files changed, 17 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz