From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUHhw-0003GD-Rn for qemu-devel@nongnu.org; Sun, 30 Mar 2014 11:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUHhl-0006Ga-Rf for qemu-devel@nongnu.org; Sun, 30 Mar 2014 11:31:36 -0400 Received: from mail-qg0-x235.google.com ([2607:f8b0:400d:c04::235]:39588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUHhl-0006FG-Ny for qemu-devel@nongnu.org; Sun, 30 Mar 2014 11:31:25 -0400 Received: by mail-qg0-f53.google.com with SMTP id z60so846624qgd.40 for ; Sun, 30 Mar 2014 08:31:24 -0700 (PDT) Sender: Richard Henderson Message-ID: <533838C8.80307@twiddle.net> Date: Sun, 30 Mar 2014 08:31:20 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1396052834-26834-1-git-send-email-rth@twiddle.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] tcg: tidy the type of code_ptr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Aurelien Jarno On 03/29/2014 01:26 PM, Peter Maydell wrote: > It seems like it might be worth abstracting out "give me the byte > difference between these two code pointers" rather than having > inline (uintptr_t)codeptr1 - (uintptr_t)codeptr2, but I dunno. Yeah, I dithered about that. I couldn't come up with a good name that adequately described what I wanted that was really any shorter than just having the casts. > Is there a better name than 'tcg_itype' ? Putting 'type' in the > name of a type is a bit redundant, and suggests it contains > a type rather than an insn. I'm open to suggestions there as well. On x86 and ia64, it won't hold an entire insn, so "tcg_insn" seemed inappropriate. r~