From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUXf2-0006xA-0c for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUXev-0004Au-VB for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:33:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34065 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUXev-0004Aq-Ii for qemu-devel@nongnu.org; Mon, 31 Mar 2014 04:33:33 -0400 Message-ID: <5339285B.1030009@suse.de> Date: Mon, 31 Mar 2014 10:33:31 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1390494179-17332-1-git-send-email-peter.maydell@linaro.org> <533922E1.6000106@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tests/Makefile: Run qom-test for every architecture List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , QEMU Developers , Stefan Hajnoczi , Patch Tracking Am 31.03.2014 10:28, schrieb Peter Maydell: > On 31 March 2014 09:10, Andreas F=C3=A4rber wrote: >> Am 23.01.2014 17:22, schrieb Peter Maydell: >>> +# Get the list of all supported sysemu targets >>> +SYSEMU_TARGET_LIST :=3D $(subst -softmmu.mak,,$(notdir \ >>> + $(wildcard $(SRC_PATH)/default-configs/*-softmmu.mak))) >>> + >>> check-unit-y =3D tests/check-qdict$(EXESUF) >>> gcov-files-check-qdict-y =3D qobject/qdict.c >>> check-unit-y +=3D tests/check-qfloat$(EXESUF) >>> @@ -71,7 +75,6 @@ check-qtest-i386-y +=3D tests/acpi-test$(EXESUF) >>> check-qtest-i386-y +=3D tests/rtc-test$(EXESUF) >>> check-qtest-i386-y +=3D tests/i440fx-test$(EXESUF) >>> check-qtest-i386-y +=3D tests/fw_cfg-test$(EXESUF) >>> -check-qtest-i386-y +=3D tests/qom-test$(EXESUF) >>> check-qtest-i386-y +=3D tests/blockdev-test$(EXESUF) >>> check-qtest-i386-y +=3D tests/qdev-monitor-test$(EXESUF) >>> check-qtest-x86_64-y =3D $(check-qtest-i386-y) >> >> qom-test gets executed twice for x86_64 now. >=20 > It doesn't for me: >=20 > TESTER check-qtest-sparc > GTESTER check-qtest-sparc64 > GTESTER check-qtest-unicore32 > GTESTER check-qtest-x86_64 > blkdebug: Suspended request 'A' > blkdebug: Resuming request 'A' > [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio > extension. Task offloads will be emulated. > GTESTER check-qtest-xtensa > GTESTER check-qtest-xtensaeb What does that prove? I said qom-test, not check-qtest-x86_64. :) You need to run `make check-qtest-x86_64 V=3D1` to see it. >> Without having debugged this further yet, my guess is this last line i= s >> causing qom-test to get added twice to check-qtest-x86_64-y, once >> inherited from check-qtest-i386-y and then newly added like for any >> other target. >=20 > When I was writing the patch I did think about whether this was > going to be a problem, but I realised that it would not, because the > check-qtest-*-y we're building up here are not lists of commands > to run, but lists of Makefile targets. Make will automatically only > run the target once even if it happens to be specified twice on the > RHS of a rule. I am not aware of a qom-test specific Makefile command - with growing number of tests that would be really handy to have for testing a newly added one quickly... Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg