From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1WUc0p-0005Ip-Qj
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 09:12:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1WUc0g-0004qE-NM
	for qemu-devel@nongnu.org; Mon, 31 Mar 2014 09:12:27 -0400
Message-ID: <533969AB.4010505@gmail.com>
Date: Mon, 31 Mar 2014 21:12:11 +0800
From: Chen Gang <gang.chen.5i5j@gmail.com>
MIME-Version: 1.0
References: <53337BEB.90305@gmail.com> <87wqfgrp83.fsf@blackfin.pond.sub.org>
	<5333F6E2.9080202@gmail.com> <53382DDD.8050001@gmail.com>
	<87fvlylf02.fsf@blackfin.pond.sub.org> <53396545.805@gmail.com>
	<CAFEAcA-GL7bnZ-Pkga9PzDq7DpwPf8Gx0Wezzkm_CCbSUB1W8A@mail.gmail.com>
In-Reply-To: <CAFEAcA-GL7bnZ-Pkga9PzDq7DpwPf8Gx0Wezzkm_CCbSUB1W8A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in
 configure_accelerator()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Anthony Liguori <aliguori@amazon.com>, QEMU Developers <qemu-devel@nongnu.org>



On 03/31/2014 09:01 PM, Peter Maydell wrote:
> On 31 March 2014 13:53, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> On 03/31/2014 08:38 PM, Markus Armbruster wrote:
>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>
>>>> Hello Maintainers:
>>>>
>>>> If it is necessary to send patch v2 by me, please let me know, I
>>>> will/should send.
>>>
>>> Not a maintainer, but if you send a v2 with an improved commit message,
>>> I'll R-by it, which can only help getting it merged.
>>>
>>
>> I guess your meaning is "not quite necessary" (for me, minor useful
>> patches almost like spam). So if sending patch v2 is really required,
>> please let me know, thanks.
> 
> Basically, asking a maintainer to make changes to a patch
> as they apply it is asking them to do extra work beyond
> what they would normally do. Sometimes people will agree
> to do this, but in general it's better just to send a fixed
> version of the patch yourself.
> 
> (I've cc'd qemu-trivial since that's probably the best tree
> to take this patch.)
> 

OK, thanks. And excuse me, my English is not quite well, I guess, I
misunderstood the original replier's meaning. I will/should send patch
v2 for it within this week (2014-04-06).

Next, when I send trivial patches, I will/should cc to qemu-trivial. I
guess, most of my future patches will be trivial patches (and for me,
trivial != minor).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed