From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUfOO-0002Rs-L8 for qemu-devel@nongnu.org; Mon, 31 Mar 2014 12:49:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUfOK-0002YT-DJ for qemu-devel@nongnu.org; Mon, 31 Mar 2014 12:49:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUfOK-0002YM-2S for qemu-devel@nongnu.org; Mon, 31 Mar 2014 12:48:56 -0400 Message-ID: <53399C73.3020208@redhat.com> Date: Mon, 31 Mar 2014 10:48:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140330203508.16278.39223.stgit@fimbulvetr.bsc.es> <20140330203520.16278.94761.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140330203520.16278.94761.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LhuAVTvnVHU4VmW100686qdOl1c8tMB3O" Subject: Re: [Qemu-devel] [PATCHv52/3] qapi: Add a primitive to include other files from a QAPI schema file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LhuAVTvnVHU4VmW100686qdOl1c8tMB3O Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/30/2014 02:35 PM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > docs/qapi-code-gen.txt | 7 +++++++ > scripts/qapi.py | 35 ++++++++++++++++++++++++++++++----- > 2 files changed, 37 insertions(+), 5 deletions(-) >=20 > diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt > index 824f6e5..1e19f64 100644 > --- a/docs/qapi-code-gen.txt > +++ b/docs/qapi-code-gen.txt > @@ -40,6 +40,13 @@ enumeration types and union types. > Generally speaking, types definitions should always use CamelCase for = the type > names. Command names should be all lower case with words separated by = a hyphen. > =20 > +The QAPI schema definitions can be modularized using the 'include' dir= ective: > + > + { 'include': 'path/to/file.json'} > + > +Include paths are relative to the file using the directive. > + See my mail to Beno=C3=AEt's series comparing your two choices of documen= tation. I didn't do a close comparison of which errors the two series could detect, but suggest that you coordinate between the two of you who will post the next version, and make sure that the different tests from both versions be incorporated into the final patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LhuAVTvnVHU4VmW100686qdOl1c8tMB3O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTOZxzAAoJEKeha0olJ0NqfB4H/0sKwYOkzepP/+eHYomXrx9T b+ZfhZAQSOSUadOP9+VXML83NlYFSeH+V7b/6aYLXLes5I68taM5a4YSLyCLY2kz DGlqPsTohNkN4j1KiSSP+NOYNQsNhlvZzhCG9S0rmCdAj3Mq5Oqd2QYlS9Y4qFFd z2CWk2QoSuAGauTDIzilxEwtTvk7CNN1WHP041Dq+NvRkZJ0sx0eGhpHLz7kRHrc GEeLZOYI5L9OWsGnuebbnTUmMKfxeAuGk7kNpNoWWnFtyS9LKPCX9KndkrPuPZLb 25lpYTb9xkHZe0cRAN2Y7Ez3tOkJbIvnu2v98tsWxV+F9fz22Hxx3UHRD2azQ6A= =Ubuc -----END PGP SIGNATURE----- --LhuAVTvnVHU4VmW100686qdOl1c8tMB3O--