From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUkET-00005X-Ru for qemu-devel@nongnu.org; Mon, 31 Mar 2014 17:59:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUkEN-0004gI-VV for qemu-devel@nongnu.org; Mon, 31 Mar 2014 17:59:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50218 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUkEN-0004gD-Ow for qemu-devel@nongnu.org; Mon, 31 Mar 2014 17:58:59 -0400 Message-ID: <5339E521.40906@suse.de> Date: Mon, 31 Mar 2014 23:58:57 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1396283195-6819-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1396283195-6819-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.0 0/7] SMBus and tmp105 fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org, "Michael S. Tsirkin" Cc: peter.maydell@linaro.org Hi, Am 31.03.2014 18:26, schrieb Paolo Bonzini: > This is a resend of the I2C patches I posted a while ago. > Patches 1-3 are just a rebase. >=20 > Patch 4 is the same as before, patches 5-7 make the tmp105 > testcase more complete in order to test that change. >=20 > Paolo Bonzini (7): > smbus: allow returning an error from reads > smbus: return -1 if nothing found at the given address > pm_smbus: correctly report unclaimed cycles I've reviewed these and they look sane and safe for 2.0. mst, could you have a second look as PC maintainer and take them? > tmp105: read temperature in milli-celsius > tmp105-test: wrap simple building blocks for testing > tmp105-test: add a second sensor and test that one > tmp105-test: test QOM property and precision Thanks, this is more than I would've done myself or asked for. I've re-broken the text paragraphs of 4/7 to fit into 76 chars and filled in the commit info in 7/7: https://github.com/afaerber/qemu-cpu/commits/qom-next And for the record, this demonstrates how pretty much any I2C device (such as ds1338) can be tested for lack of other libqos drivers: Add it via -device to n800 or n810 machine using a free address (such as 0x49 here) and give the device an ID for accessing it via /machine/peripheral/ (just shorthand here, I let that slip through). > hw/i2c/pm_smbus.c | 63 +++++++++++++++-------- > hw/i2c/smbus.c | 68 +++++++++++++++++-------- > hw/misc/tmp105.c | 8 +-- > include/hw/i2c/smbus.h | 18 +++---- > roms/SLOF | 2 +- > roms/openbios | 2 +- > roms/qemu-palcode | 2 +- > roms/seabios | 2 +- > tests/tmp105-test.c | 136 +++++++++++++++++++++++++++++++++++++++++= -------- > 9 files changed, 220 insertions(+), 81 deletions(-) This diffstat luckily differs from the patches. Please double-check your setup. :) Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg