From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1WUyxM-0001sL-Ae
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 09:42:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1WUyxD-0005th-AX
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 09:42:24 -0400
Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:54823)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gang.chen.5i5j@gmail.com>) id 1WUyxD-0005tG-3V
	for qemu-devel@nongnu.org; Tue, 01 Apr 2014 09:42:15 -0400
Received: by mail-pa0-f41.google.com with SMTP id fa1so9843040pad.14
	for <qemu-devel@nongnu.org>; Tue, 01 Apr 2014 06:42:14 -0700 (PDT)
Message-ID: <533AC230.3050404@gmail.com>
Date: Tue, 01 Apr 2014 21:42:08 +0800
From: Chen Gang <gang.chen.5i5j@gmail.com>
MIME-Version: 1.0
References: <53382B89.9030301@gmail.com>	<87zjk6fjwf.fsf@blackfin.pond.sub.org>
	<533A0442.2020606@gmail.com>	<87wqf95uwu.fsf@blackfin.pond.sub.org>
	<533A8077.10509@gmail.com> <87vbuti37t.fsf@blackfin.pond.sub.org>
In-Reply-To: <87vbuti37t.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH trival] vl.c: clean up code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, aliguori@amazon.com

On 04/01/2014 09:33 PM, Markus Armbruster wrote:
> Chen Gang <gang.chen.5i5j@gmail.com> writes:
> 
>> On 04/01/2014 04:13 PM, Markus Armbruster wrote:
>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>
>>>> On 03/31/2014 11:49 PM, Markus Armbruster wrote:
>>>>> Chen Gang <gang.chen.5i5j@gmail.com> writes:
>>>>>
>>>>>> in get_boot_device()
>>>>>>
>>>>>>  - remove 'res' to simplify code
>>>>>>
>>>>>> in main():
>>>>>>
>>>>>>  - remove useless 'continue'.
>>>>>>
>>>>>>  - in main switch():
>>>>>>
>>>>>>    - remove or adjust all useless 'break'.
>>>>>>
>>>>>>    - remove useless '{' and '}'.
>>>>>>
>>>>>>  - use assignment directly to replace useless 'args'
>>>>>>    (which is defined in the middle of code block).
>>>>>
>>>>> Suggest to have one patch per item in this list.
>>>>>
>>>>
>>>> OK, thanks. I will/should send again in this week (within 2014-04-06).
>>>
>>> No rush :)
>>>
>>
>> Yeah, more discussions, and more thinking of, before implementations.
> 
> What I meant to say is "next week is fine, we're not in a big hurry to
> get this done".
> 

OK, thanks. :-)


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed