From: Cole Robinson <crobinso@redhat.com>
To: Takashi Iwai <tiwai@suse.de>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode
Date: Wed, 02 Apr 2014 09:26:01 -0400 [thread overview]
Message-ID: <533C0FE9.9010607@redhat.com> (raw)
In-Reply-To: <1396441953-19260-3-git-send-email-tiwai@suse.de>
On 04/02/2014 08:32 AM, Takashi Iwai wrote:
> The relative pointer tracking mode was still buggy even after the
> previous fix of the motion-notify-event since the events are filtered
> out when the pointer moves outside the drawing window due to the
> boundary check for the absolute mode.
>
> This patch fixes the issue by moving the unnecessary boundary check
> into the if block of absolute mode, and keep the coordinate in the
> relative mode even if it's outside the drawing area. But this makes
> the coordinate (last_x, last_y) possibly pointing to (-1,-1),
> introduce a new flag to indicate the last coordinate has been
> updated.
>
> Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Tested-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Thanks,
Cole
next prev parent reply other threads:[~2014-04-02 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 12:32 [Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2) Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event Takashi Iwai
2014-04-02 13:25 ` Cole Robinson
2014-04-02 15:17 ` Gerd Hoffmann
2014-04-02 15:26 ` Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode Takashi Iwai
2014-04-02 13:26 ` Cole Robinson [this message]
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position Takashi Iwai
2014-04-02 13:27 ` Cole Robinson
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option Takashi Iwai
2014-04-02 13:28 ` Cole Robinson
2014-04-02 13:42 ` Takashi Iwai
2014-04-02 13:49 ` Cole Robinson
2014-04-02 14:39 ` Gerd Hoffmann
2014-04-02 15:07 ` [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode Cole Robinson
2014-04-02 15:19 ` Gerd Hoffmann
2014-04-02 15:25 ` Takashi Iwai
2014-04-02 20:18 ` Cole Robinson
2014-04-03 6:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C0FE9.9010607@redhat.com \
--to=crobinso@redhat.com \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).