From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVLBF-0000Al-0M for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:26:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVLBA-0001dH-C7 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:26:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVLBA-0001d9-31 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:26:08 -0400 Message-ID: <533C0FE9.9010607@redhat.com> Date: Wed, 02 Apr 2014 09:26:01 -0400 From: Cole Robinson MIME-Version: 1.0 References: <1396441953-19260-1-git-send-email-tiwai@suse.de> <1396441953-19260-3-git-send-email-tiwai@suse.de> In-Reply-To: <1396441953-19260-3-git-send-email-tiwai@suse.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Takashi Iwai , qemu-devel@nongnu.org Cc: kraxel@redhat.com, Anthony Liguori On 04/02/2014 08:32 AM, Takashi Iwai wrote: > The relative pointer tracking mode was still buggy even after the > previous fix of the motion-notify-event since the events are filtered > out when the pointer moves outside the drawing window due to the > boundary check for the absolute mode. > > This patch fixes the issue by moving the unnecessary boundary check > into the if block of absolute mode, and keep the coordinate in the > relative mode even if it's outside the drawing area. But this makes > the coordinate (last_x, last_y) possibly pointing to (-1,-1), > introduce a new flag to indicate the last coordinate has been > updated. > > Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 > Signed-off-by: Takashi Iwai Tested-by: Cole Robinson Reviewed-by: Cole Robinson Thanks, Cole