From: "Andreas Färber" <andreas.faerber@web.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] prep: remove CPU reset entry point hack related to OpenHack'Ware
Date: Wed, 02 Apr 2014 15:47:24 +0200 [thread overview]
Message-ID: <533C14EC.40408@web.de> (raw)
In-Reply-To: <533C0706.40805@redhat.com>
Am 02.04.2014 14:48, schrieb Paolo Bonzini:
> Il 01/04/2014 23:19, Hervé Poussineau ha scritto:
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>
>> ---
>> hw/ppc/prep.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
>> index 035b5b2..dfe4a5c 100644
>> --- a/hw/ppc/prep.c
>> +++ b/hw/ppc/prep.c
>> @@ -346,9 +346,6 @@ static void ppc_prep_reset(void *opaque)
>> PowerPCCPU *cpu = opaque;
>>
>> cpu_reset(CPU(cpu));
>> -
>> - /* Reset address */
>> - cpu->env.nip = 0xfffffffc;
>> }
>>
>> static const MemoryRegionPortio prep_portio_list[] = {
>>
>
> Is ppc_prep_reset needed at all now?
I believe so, CPU reset is historically handled by the machines rather
than by CPUs themselves. (also Alpha is an oddball in not handling nor
implementing reset - some WIP on qom-cpu-alpha)
Regards,
Andreas
prev parent reply other threads:[~2014-04-02 13:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 21:19 [Qemu-devel] [PATCH for-2.0 0/2] prep: remove last OHW hacks Hervé Poussineau
2014-04-01 21:19 ` [Qemu-devel] [PATCH for-2.0 1/2] prep: remove PCI memory hack related to OpenHack'Ware Hervé Poussineau
2014-04-01 21:19 ` [Qemu-devel] [PATCH for-2.0 2/2] prep: remove CPU reset entry point " Hervé Poussineau
2014-04-02 12:48 ` Paolo Bonzini
2014-04-02 13:47 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533C14EC.40408@web.de \
--to=andreas.faerber@web.de \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).