From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WVLWR-0000ZL-8a
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:48:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1WVLWL-0000wH-1l
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:48:07 -0400
Message-ID: <533C14EC.40408@web.de>
Date: Wed, 02 Apr 2014 15:47:24 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1396387156-5817-1-git-send-email-hpoussin@reactos.org>
	<1396387156-5817-3-git-send-email-hpoussin@reactos.org>
	<533C0706.40805@redhat.com>
In-Reply-To: <533C0706.40805@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.0 2/2] prep: remove CPU reset entry
 point hack related to OpenHack'Ware
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org

Am 02.04.2014 14:48, schrieb Paolo Bonzini:
> Il 01/04/2014 23:19, Hervé Poussineau ha scritto:
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>>
>> ---
>>  hw/ppc/prep.c |    3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
>> index 035b5b2..dfe4a5c 100644
>> --- a/hw/ppc/prep.c
>> +++ b/hw/ppc/prep.c
>> @@ -346,9 +346,6 @@ static void ppc_prep_reset(void *opaque)
>>      PowerPCCPU *cpu = opaque;
>>
>>      cpu_reset(CPU(cpu));
>> -
>> -    /* Reset address */
>> -    cpu->env.nip = 0xfffffffc;
>>  }
>>
>>  static const MemoryRegionPortio prep_portio_list[] = {
>>
> 
> Is ppc_prep_reset needed at all now?

I believe so, CPU reset is historically handled by the machines rather
than by CPUs themselves. (also Alpha is an oddball in not handling nor
implementing reset - some WIP on qom-cpu-alpha)

Regards,
Andreas