From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVLXU-0001UT-SV for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:49:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVLXO-00015c-Jq for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:49:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVLXO-00015S-B5 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 09:49:06 -0400 Message-ID: <533C154E.7040005@redhat.com> Date: Wed, 02 Apr 2014 09:49:02 -0400 From: Cole Robinson MIME-Version: 1.0 References: <1396441953-19260-1-git-send-email-tiwai@suse.de> <1396441953-19260-5-git-send-email-tiwai@suse.de> <533C1096.30904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Takashi Iwai Cc: qemu-devel@nongnu.org, Anthony Liguori , kraxel@redhat.com On 04/02/2014 09:42 AM, Takashi Iwai wrote: > At Wed, 02 Apr 2014 09:28:54 -0400, > Cole Robinson wrote: >> >> On 04/02/2014 08:32 AM, Takashi Iwai wrote: >>> I simply like it better, you don't? :) >>> >> >> In fact, relative mouse mode is a pain without this feature, you need to >> manually initiate a grab with ctrl+alt+g before mouse movement will even work. >> Compare to our sdl front end, or virt-viewer, vinagre, virt-manager, where >> grab-on-click is the default (there isn't even an option to disable that >> behavior). >> >> I don't know what the original intention of the code was, but I think this >> behavior should be the default. Anthony, Gerd, thoughts? > > I noticed later that the original gtk-ui behavior is better when > vmmouse driver is available, i.e. the absolute mode is working. With > grab-on-click, you have to ungrab at each time you want to leave from > VM window. > > So I think we should leave the default behavior as is, since vmmouse > driver is likely available in most cases. But, still having this in > the menu makes our lives easier in case vmmouse isn't available or > doesn't work with QEMU. > Or we just do what sdl.c does (and virt-viewer, and vinagre, and virt-manager): absolute mode == grab on hover, ungrab when pointer leaves the window relative mode == grab on click, require manual ungrab - Cole