From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVQHN-0000cu-PF for qemu-devel@nongnu.org; Wed, 02 Apr 2014 14:53:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVQHE-0001UD-IJ for qemu-devel@nongnu.org; Wed, 02 Apr 2014 14:52:53 -0400 Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:60865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVQHE-0001Tj-Ev for qemu-devel@nongnu.org; Wed, 02 Apr 2014 14:52:44 -0400 Received: by mail-qc0-f170.google.com with SMTP id x13so709813qcv.29 for ; Wed, 02 Apr 2014 11:52:43 -0700 (PDT) Sender: Richard Henderson Message-ID: <533C5C72.70200@twiddle.net> Date: Wed, 02 Apr 2014 11:52:34 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1396447598-11205-1-git-send-email-andreas.faerber@web.de> In-Reply-To: <1396447598-11205-1-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 04/02/2014 07:06 AM, Andreas Färber wrote: > FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h, > which leads to a conflict with our static inline definitions. > > Force using the system version of the macros. > > Signed-off-by: Andreas Färber > --- > On 9.0-RELEASE I did not have this issue, so unsure if some version check > is needed or some more generic configure check? Looks plausible, but I have no bsd specific experience. I'd say if it works for both 9.0 and 10.0, let it go in as is. r~