From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WVRc9-0000wv-BW
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:18:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WVRc3-0002h6-6s
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:18:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crobinso@redhat.com>) id 1WVRc2-0002gt-Uu
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:18:19 -0400
Message-ID: <533C7087.1030101@redhat.com>
Date: Wed, 02 Apr 2014 16:18:15 -0400
From: Cole Robinson <crobinso@redhat.com>
MIME-Version: 1.0
References: <1396449543.31715.7.camel@nilsson.home.kraxel.org>	<6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com>	<1396451991.31715.25.camel@nilsson.home.kraxel.org>
	<s5hob0jsqhw.wl%tiwai@suse.de>
In-Reply-To: <s5hob0jsqhw.wl%tiwai@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in
	relative mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Takashi Iwai <tiwai@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 04/02/2014 11:25 AM, Takashi Iwai wrote:
> At Wed, 02 Apr 2014 17:19:51 +0200,
> Gerd Hoffmann wrote:
>>
>> On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote:
>>> +    if (button->button == 1 &&
>>> +        button->type == GDK_BUTTON_PRESS &&
>>> +        !gd_is_grab_active(s) &&
>>> +        !qemu_input_is_absolute()) {
>>> +
>>> gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
>>> +                                       TRUE);
>>> +        return TRUE;
>>> +    }
>>
>> Looks sane on a quick glance (as replacement for patch #4 of Takashi's
>> patch series).  Didn't test yet.
> 
> Unfortunately, this doesn't work perfectly as expected.
> The input mode change happens after the first click action, thus
> this always results in grabbing if you do left-click at first, even
> after X starts up and vmmouse gets active.
> 
> I thought of checking it via notifier, but the notification happens
> also after the first mouse click event.  Hmm.

We could ungrab the pointer if transitioning from relative to absolute mode,
that's effectively what virt-viewer/remote-viewer does (though it also
completely disallows pointer grab in absolute mode... not sure we want to go
that far).

- Cole