From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVRqu-0006Hv-6v for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:33:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVRqn-0008JO-86 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:33:40 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:47785 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVRqm-0008J9-R4 for qemu-devel@nongnu.org; Wed, 02 Apr 2014 16:33:33 -0400 Message-ID: <533C741A.6020809@kamp.de> Date: Wed, 02 Apr 2014 22:33:30 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1396443917-3647-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1396443917-3647-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 02.04.2014 15:05, schrieb Paolo Bonzini: > Non-block SCSI devices do not support flushing, but we may still send > them requests via bdrv_flush_all. Just ignore them. > > Signed-off-by: Paolo Bonzini > --- > block/iscsi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/block/iscsi.c b/block/iscsi.c > index 0d15b4d..00316af 100644 > --- a/block/iscsi.c > +++ b/block/iscsi.c > @@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs) > IscsiLun *iscsilun = bs->opaque; > struct IscsiTask iTask; > > + if (bs->sg) { > + return 0; > + } > + > iscsi_co_init_iscsitask(iscsilun, &iTask); > > retry: Reviewed-by: Peter Lieven