* [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices
@ 2014-04-02 13:05 Paolo Bonzini
2014-04-02 20:33 ` Peter Lieven
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2014-04-02 13:05 UTC (permalink / raw)
To: qemu-devel; +Cc: pl
Non-block SCSI devices do not support flushing, but we may still send
them requests via bdrv_flush_all. Just ignore them.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 0d15b4d..00316af 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs)
IscsiLun *iscsilun = bs->opaque;
struct IscsiTask iTask;
+ if (bs->sg) {
+ return 0;
+ }
+
iscsi_co_init_iscsitask(iscsilun, &iTask);
retry:
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices
2014-04-02 13:05 [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices Paolo Bonzini
@ 2014-04-02 20:33 ` Peter Lieven
0 siblings, 0 replies; 2+ messages in thread
From: Peter Lieven @ 2014-04-02 20:33 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
Am 02.04.2014 15:05, schrieb Paolo Bonzini:
> Non-block SCSI devices do not support flushing, but we may still send
> them requests via bdrv_flush_all. Just ignore them.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/iscsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 0d15b4d..00316af 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs)
> IscsiLun *iscsilun = bs->opaque;
> struct IscsiTask iTask;
>
> + if (bs->sg) {
> + return 0;
> + }
> +
> iscsi_co_init_iscsitask(iscsilun, &iTask);
>
> retry:
Reviewed-by: Peter Lieven <pl@kamp.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-02 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 13:05 [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices Paolo Bonzini
2014-04-02 20:33 ` Peter Lieven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).