qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
	Hong-Hua Yin <Hong-Hua.Yin@freescale.com>
Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming
Date: Thu, 03 Apr 2014 19:44:27 +1100	[thread overview]
Message-ID: <533D1F6B.4080906@ozlabs.ru> (raw)
In-Reply-To: <53189FCE.2010601@suse.de>

On 03/07/2014 03:18 AM, Andreas Färber wrote:
> Am 06.03.2014 04:11, schrieb Alexey Kardashevskiy:
>> Previously libvirt required the first/default PCI bus to have name "pci".
>> Since QEMU can support multiple buses now, libvirt wants "pci.0" now.
>>
>> This removes custom busname and lets QEMU make up default names.



Ufff. Does anyone know any workaround how to tell libvirt to use these
custom names? Since there is no "pci" (and there is "pci.0"), libvirt
cannot put any device onto default PCI bus and I do not see any way to
workaround it in XML, am I missing something here?


>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>
>> I tested this with:
>>   -netdev tap,id=id0,ifname=tapqemu-tap-00,script=ifup.sh,downscript=ifdown.sh \
>>   -device e1000,id=id1,netdev=id0,mac=C0:41:49:4b:00:00 \
>>   -device \
>>   spapr-pci-host-bridge,index=5,id=aikbus \
>>   -netdev tap,id=id2,ifname=tap-1,script=ifup.sh,downscript=ifdown.sh \
>>   -device rtl8139,id=id3,netdev=id2,bus=aikbus.0,mac=C0:41:49:4b:00:01 \
>>   -device spapr-pci-vfio-host-bridge,id=id4,index=10,iommu=4 \
>>
>> This creates a default PCI, an additional emulated PCI bus (named aikbus,
> 
> aikbus.0 for the bus according to example and info qtree, but yeah ;)
> 
>> if I omit the name, it is pci.1 which is also fine) and VFIO bus (which is
>> not in upstream yet but still), this all works fine and I cannot see any flaw.
>>
>>
>> ---
>>  hw/ppc/spapr_pci.c | 23 ++---------------------
>>  1 file changed, 2 insertions(+), 21 deletions(-)
> 
> Thanks, in absence of Alex applying to qom-next:
> https://github.com/afaerber/qemu-cpu/commits/qom-next
> 
> Andreas
> 


-- 
Alexey

  reply	other threads:[~2014-04-03  8:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06  3:11 [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming Alexey Kardashevskiy
2014-03-06 11:47 ` Paolo Bonzini
2014-03-06 11:50   ` Daniel P. Berrange
2014-03-06 11:51     ` Paolo Bonzini
2014-03-06 16:18 ` Andreas Färber
2014-04-03  8:44   ` Alexey Kardashevskiy [this message]
2014-04-03 11:09     ` Paolo Bonzini
2014-04-03 12:31       ` Alexey Kardashevskiy
2014-04-04  1:59       ` Hong-Hua.Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D1F6B.4080906@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=Hong-Hua.Yin@freescale.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).