From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36735)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WViCs-0006hE-5Q
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 10:01:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WViCh-0001Af-Vu
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 10:01:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WViCh-00019k-OL
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 10:01:15 -0400
Message-ID: <533D699B.3050502@redhat.com>
Date: Thu, 03 Apr 2014 16:00:59 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1396532854-16007-1-git-send-email-olaf@aepfle.de>
In-Reply-To: <1396532854-16007-1-git-send-email-olaf@aepfle.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] megasas: remove buildtime strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Olaf Hering <olaf@aepfle.de>, qemu-devel@nongnu.org

Il 03/04/2014 15:47, Olaf Hering ha scritto:
> Using __DATE__ or __TIME__ in binary pkgs changes the checksum of
> compiled binaries if they get rebuilt, even if there are no other
> source changes.  Replace the dynamic strings with some equally
> informative static strings.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>
> Or remove both lines alltogether. You decide.
>
>  hw/scsi/megasas.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index e6e1ffd..db89227 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -717,8 +717,8 @@ static int megasas_ctrl_get_info(MegasasState *s, MegasasCmd *cmd)
>      snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION);
>      memcpy(info.image_component[0].name, "APP", 3);
>      memcpy(info.image_component[0].version, MEGASAS_VERSION "-QEMU", 9);
> -    memcpy(info.image_component[0].build_date, __DATE__, 11);
> -    memcpy(info.image_component[0].build_time, __TIME__, 8);
> +    memcpy(info.image_component[0].build_date, "Apr  1 2014", 11);
> +    memcpy(info.image_component[0].build_time, "12:34:56", 8);
>      info.image_component_count = 1;
>      if (pci_dev->has_rom) {
>          uint8_t biosver[32];
>

Applied to scsi-next, thanks.

Paolo