From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
patches@linaro.org,
"Andrei E. Warkentin" <andrey.warkentin@gmail.com>
Subject: Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation
Date: Thu, 03 Apr 2014 09:51:47 -0700 [thread overview]
Message-ID: <533D91A3.6020802@twiddle.net> (raw)
In-Reply-To: <1396543508-12280-3-git-send-email-peter.maydell@linaro.org>
On 04/03/2014 09:45 AM, Peter Maydell wrote:
> + if (have_tb_lock) {
> + spin_unlock(&tcg_ctx.tb_ctx.tb_lock);
> + }
It ought not matter, since we ought to exit the loop on the next round, but i
have a strong preference for resetting have_tb_lock here.
Otherwise, this is nicely self-contained.
r~
next prev parent reply other threads:[~2014-04-03 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:45 [Qemu-devel] [PATCH for-2.0? 0/2] fix bugs involving linux-user signal handling Peter Maydell
2014-04-03 16:45 ` [Qemu-devel] [PATCH for-2.0? 1/2] page_check_range: don't bail out early after unprotecting page Peter Maydell
2014-04-03 18:26 ` Richard Henderson
2014-04-03 16:45 ` [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation Peter Maydell
2014-04-03 16:51 ` Richard Henderson [this message]
2014-04-03 16:53 ` Peter Maydell
2014-04-03 19:38 ` Andrei E. Warkentin
2014-04-03 23:24 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D91A3.6020802@twiddle.net \
--to=rth@twiddle.net \
--cc=andrey.warkentin@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).