From: "Andreas Färber" <afaerber@suse.de>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Cc: aik@au1.ibm.com, Mark Wu <wudxw@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults
Date: Thu, 03 Apr 2014 19:12:46 +0200 [thread overview]
Message-ID: <533D968E.7030306@suse.de> (raw)
In-Reply-To: <871txez6jd.fsf@abhimanyu.in.ibm.com>
Am 03.04.2014 19:06, schrieb Nikunj A Dadhania:
>
> The following commit caused the regression in qemu-system-ppc64
>
> 7effdaa3: spapr: Fix return value of vga initialization
> d44229c5: Fix vga_interface_type for command line argument '-device VGA'
>
> Even when -nodefaults was provided, USB Keyboard and Mouse was added
> to the machine. This breaks libvirt which uses -nodefaults and adds
> the keyboard and mouse separately. The machine got 2 USB Keyboards
> and 2 USB Mouses.
>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Mark Wu <wudxw@linux.vnet.ibm.com>
> CC: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-04-03 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:56 [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults Nikunj A Dadhania
2014-04-03 17:01 ` Andreas Färber
2014-04-03 17:07 ` Nikunj A Dadhania
2014-04-03 17:06 ` Nikunj A Dadhania
2014-04-03 17:12 ` Andreas Färber [this message]
2014-04-04 6:34 ` Markus Armbruster
2014-04-04 8:28 ` Nikunj A Dadhania
2014-04-04 10:58 ` Markus Armbruster
2014-04-04 11:00 ` Paolo Bonzini
2014-04-04 11:23 ` Markus Armbruster
2014-04-04 15:08 ` Eric Blake
2014-04-04 13:14 ` Andreas Färber
2014-04-03 18:01 ` Paolo Bonzini
2014-04-03 18:32 ` Eric Blake
2014-04-03 19:24 ` Nikunj A Dadhania
2014-04-03 19:37 ` Paolo Bonzini
2014-04-04 5:28 ` Nikunj A Dadhania
2014-04-04 11:02 ` Paolo Bonzini
2014-04-04 11:40 ` Nikunj A Dadhania
2014-04-04 11:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D968E.7030306@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@au1.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wudxw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).