From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVltb-0004kC-5c for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVltT-0004iH-M1 for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:57:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:33660 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVltT-0004i4-Gx for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:57:39 -0400 Message-ID: <533DA110.3000005@suse.de> Date: Thu, 03 Apr 2014 19:57:36 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1396257993-4036-1-git-send-email-marcel.a@redhat.com> <1396257993-4036-5-git-send-email-marcel.a@redhat.com> <533D997A.6040604@suse.de> <1396547206.24348.55.camel@localhost.localdomain> In-Reply-To: <1396547206.24348.55.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine indirection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, agraf@suse.de, alex@alex.org.uk, pbonzini@redhat.com, lcapitulino@redhat.com, aliguori@amazon.com Am 03.04.2014 19:46, schrieb Marcel Apfelbaum: > On Thu, 2014-04-03 at 19:25 +0200, Andreas F=C3=A4rber wrote: >> Am 31.03.2014 11:26, schrieb Marcel Apfelbaum: >>> No need for QEMUMachine anymore because >>> its fields are passed to MachineClass. >> >> QEMUMachineInitArgs still has a QEMUMachine field that now becomes NUL= L? > No...=20 > It is properly initiated right before the machine init: (No changes mad= e) >=20 >=20 > QEMUMachineInitArgs args =3D { .machine =3D machine,=20 > .ram_size =3D ram_size,=20 > .boot_order =3D boot_order,=20 > .kernel_filename =3D kernel_filename,=20 > .kernel_cmdline =3D kernel_cmdline,=20 > .initrd_filename =3D initrd_filename,=20 > .cpu_model =3D cpu_model };=20 > =20 > current_machine->init_args =3D args;=20 > machine->init(¤t_machine->init_args); You're dropping pseries QEMUMachine in this patch, =3D> mc->qemu_machine =3D NULL =3D> machine =3D NULL =3D> .machine =3D NULL Therefore my suggestion to start using MachineClass for .machine early (because machine_class !=3D NULL) and to do the ->qemu_machine and mc-> changes in one go (so that ->qemu_machine !=3D NULL as long as it exists)= . Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg