From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVmRg-0004gp-Om for qemu-devel@nongnu.org; Thu, 03 Apr 2014 14:33:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVmRb-0007ri-QW for qemu-devel@nongnu.org; Thu, 03 Apr 2014 14:33:00 -0400 Message-ID: <533DA94F.2020809@redhat.com> Date: Thu, 03 Apr 2014 12:32:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396544174-8904-1-git-send-email-nikunj@linux.vnet.ibm.com> <533DA210.2010303@redhat.com> In-Reply-To: <533DA210.2010303@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n00okfGwBBGDn4so4MsKuMIvnFSC0qCiW" Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Nikunj A Dadhania , qemu-devel@nongnu.org, agraf@suse.com Cc: qemu-ppc@nongnu.org, Mark Wu , aik@au1.ibm.com, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n00okfGwBBGDn4so4MsKuMIvnFSC0qCiW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/03/2014 12:01 PM, Paolo Bonzini wrote: > Il 03/04/2014 18:56, Nikunj A Dadhania ha scritto: >> The following commit caused the regression in qemu-system-ppc64 >> >> 7effdaa3: spapr: Fix return value of vga initialization >> d44229c5: Fix vga_interface_type for command line argument '-device VG= A' >> >> Even when -nodefaults was provided, USB Keyboard and Mouse was added >> to the machine. This breaks libvirt which uses -nodefaults and adds >> the keyboard and mouse separately. The machine got 2 USB Keyboards >> and 2 USB Mouses. s/Mouses/Mice/ >=20 > Does libvirt use "-nodefaults -machine usb=3Dtrue"? It should create t= he > OHCI controller separately instead of using "-machine". At least with x86 emulation, libvirt prefers '-nodefaults -machine usb=3Doff -device piix3-usb-uhci'; so I'm assuming libvirt knows how to directly create the USB devices it needs. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --n00okfGwBBGDn4so4MsKuMIvnFSC0qCiW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTPalPAAoJEKeha0olJ0Nq3TYH/3JY44bl4ekeE+cgdBVcEldp IdeYkeGiBu0/6UwR2NiJdGOnxw3f35/ZUXsrGKI80YfYYH0eh2tt1ScQphTtQqv4 t5ipyLnH72/BDdcquTW+dtZCGEj1NzCiG9SjYUgtHPW2YWRZhlzfylqrXjI/ny2F B9Na2cySwIveg05A9zi2ydldH0rubLYBcLipYR1PvGQtkfpI1XK/SHgtBlG0N0JG qmijaO2VsH8qoo7UhwjBGTS8uejiPUYFzTj3vCucgD9yoAQf+4iEvvt1w6hkrZEL 9j0ClTw1J3ZzYAKM901g8LRwcWARNXU4UbWZhJKdWEa57YjCE2JATVA15DeYTmE= =L3X8 -----END PGP SIGNATURE----- --n00okfGwBBGDn4so4MsKuMIvnFSC0qCiW--