From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WVmYR-0008Fo-Kd
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 14:40:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WVmYL-0003D6-Kk
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 14:39:59 -0400
Message-ID: <533DAAF6.1000104@suse.de>
Date: Thu, 03 Apr 2014 20:39:50 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <533D7C1D.6020008@greensocs.com> <533D7E54.1000506@suse.de>
	<533D93A4.4040200@greensocs.com>
	<EE8A72AC-3E83-4C79-ACE6-475F6FE82EEF@suse.de>
In-Reply-To: <EE8A72AC-3E83-4C79-ACE6-475F6FE82EEF@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Bug with smp ppc guest.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, Frederic Konrad <fred.konrad@greensocs.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-ppc <qemu-ppc@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>, gkurz@linux.vnet.ibm.com

Am 03.04.2014 20:26, schrieb Alexander Graf:
>=20
> On 03.04.2014, at 19:00, Frederic Konrad <fred.konrad@greensocs.com> wr=
ote:
>=20
>> On 03/04/2014 17:29, Andreas F=E4rber wrote:
>>> Hi Fred,
>>>
>>> Am 03.04.2014 17:19, schrieb Frederic Konrad:
>>>> I tried to boot a mpc85xx smp image with a new platform inside qemu.
>>>>
>>>> This command line reproduce the issue:
>>>> ./ppc-softmmu/qemu-system-ppc -M mpc8544ds -kernel zImage --smp 2
>>>>
>>>> This use to work but since this commit:
>>>> d197fdbc3b83655f3c145722805f0998c04dce16
>>>>
>>>>
>>>> target-ppc: Reset SPRs on CPU reset
>>>>
>>>>    =20
>>>>     This resets SPR values to defaults on CPU reset. This should hel=
p
>>>>
>>>>     with little-endian guests reboot issues.
>>>>
>>>> I get some errors inside the guest:
>>> Is this after today's fix?
>>>
>>> http://git.qemu-project.org/?p=3Dqemu.git;a=3Dcommit;h=3D87d8354de356=
0eb705bcee83142d775f703177a6
>>>
>>> Regards,
>>> Andreas
>>>
>> Hi Andreas,
>>
>> I just tried seems it doesn't make any difference for me ;).
>=20
> That patch should only have an effect when you're running with KVM whic=
h you probably don't :).
>=20
> I can see the same breakage here, but only when my guest kernel is e500=
v2. With an e500mc kernel (even for -M mpc8544ds) it works fine. The seco=
ndary core also does get woken up. So it's probably something related to =
SPE emulation - hrm.

I think I found it:

hw/ppc/e500.c:
        env->spr[SPR_BOOKE_PIR] =3D cs->cpu_index =3D i;

With this patch this gets overwritten to spr->default_value, so the CPUs
end up having the same value on reset.

http://git.qemu-project.org/?p=3Dqemu.git;a=3Dblobdiff;f=3Dtarget-ppc/tra=
nslate_init.c;h=3D954dee3ec27b6a00559c878b8248ec6a07f35d79;hp=3D6084f40f2=
8a62903e59db40771f33dd3e2c2996d;hb=3Dd197fdbc3b83655f3c145722805f0998c04d=
ce16;hpb=3D7aaf4957efad2bf6ac449d0caa9a1535f61006bc

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg