From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVuYs-0007eI-D8 for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVuYj-0003BP-AZ for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:12:58 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:55909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVuYj-0003BL-6K for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:12:49 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Apr 2014 23:12:48 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 3410E6E803F for ; Thu, 3 Apr 2014 23:12:39 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s343Cjtk9437444 for ; Fri, 4 Apr 2014 03:12:45 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s343CigM007870 for ; Thu, 3 Apr 2014 23:12:45 -0400 Message-ID: <533E22D8.3020500@linux.vnet.ibm.com> Date: Fri, 04 Apr 2014 11:11:20 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com> <874n341kq8.fsf@elfo.mitica> In-Reply-To: <874n341kq8.fsf@elfo.mitica> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, BIRAN@il.ibm.com, hinesmr@cn.ibm.com, qemu-devel@nongnu.org, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, junqing.wang@cs2c.com.cn, lig.fnst@cn.fujitsu.com, gokul@us.ibm.com, dbulkow@gmail.com, pbonzini@redhat.com, abali@us.ibm.com, isaku.yamahata@gmail.com, "Michael R. Hines" On 03/12/2014 05:36 AM, Juan Quintela wrote: > mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> During micro-checkpointing, the VCPUs get repeatedly paused and >> resumed. We need to not freak out when the VM begins micro-checkpointing. >> >> Signed-off-by: Michael R. Hines >> diff --git a/include/migration/migration.h b/include/migration/migration.h >> index 3e1e6c7..9c62e2f 100644 >> --- a/include/migration/migration.h >> +++ b/include/migration/migration.h >> @@ -121,10 +121,31 @@ uint64_t skipped_mig_bytes_transferred(void); >> uint64_t skipped_mig_pages_transferred(void); >> uint64_t norm_mig_bytes_transferred(void); >> uint64_t norm_mig_pages_transferred(void); >> +uint64_t norm_mig_log_dirty_time(void); >> +uint64_t norm_mig_bitmap_time(void); >> uint64_t xbzrle_mig_bytes_transferred(void); >> uint64_t xbzrle_mig_pages_transferred(void); >> uint64_t xbzrle_mig_pages_overflow(void); >> uint64_t xbzrle_mig_pages_cache_miss(void); >> +void acct_clear(void); >> + >> +void migrate_set_state(MigrationState *s, int old_state, int new_state); >> + >> +enum { >> + MIG_STATE_ERROR = -1, >> + MIG_STATE_NONE, >> + MIG_STATE_SETUP, >> + MIG_STATE_CANCELLED, >> + MIG_STATE_CANCELLING, >> + MIG_STATE_ACTIVE, >> + MIG_STATE_CHECKPOINTING, >> + MIG_STATE_COMPLETED, >> +}; >> + >> +int mc_enable_buffering(void); >> +int mc_start_buffer(void); >> +void mc_init_checkpointer(MigrationState *s); >> +void mc_process_incoming_checkpoints_if_requested(QEMUFile *f); >> >> void ram_handle_compressed(void *host, uint8_t ch, uint64_t size); >> > This clearly don't work on this patch. > > Rest of it is ok. > > Later, Juan. > Yeah, I was lazy - I'll split it out correctly next time.