Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states

["Michael R. Hines" <mrhines@linux.vnet.ibm.com>]

On 03/12/2014 05:40 AM, Eric Blake wrote:
>> +++ b/qapi-schema.json
>> @@ -169,6 +169,8 @@
>>   #
>>   # @save-vm: guest is paused to save the VM state
>>   #
>> +# @checkpoint-vm: guest is paused to checkpoint the VM state
>> +#
> It would be nice to mention '(since 2.1)'.

Acknowledged.

>>   # @shutdown: guest is shut down (and -no-shutdown is in use)
>>   #
>>   # @suspended: guest is suspended (ACPI S3)
>> @@ -181,7 +183,7 @@
>>     'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
>>               'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
>>               'running', 'save-vm', 'shutdown', 'suspended', 'watchdog',
>> -            'guest-panicked' ] }
>> +            'guest-panicked', 'checkpoint-vm' ] }
> It would also be nice to document the enum variables in the same order
> you declare them.  The declaration of 'checkpoint-vm' does not have to
> be at the end; we use named enums precisely so that the QMP interface is
> not tied to the C integer value underlying the enum.
>

Acknowledged.

- Michael