From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVuZw-00008S-5N for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:14:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVuZn-0003Ic-3n for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:14:04 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:33274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVuZm-0003IY-Uz for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:13:55 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Apr 2014 23:13:54 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id F06AC6E8041 for ; Thu, 3 Apr 2014 23:13:46 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s343Drmi5898712 for ; Fri, 4 Apr 2014 03:13:53 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s343Dpi7010129 for ; Thu, 3 Apr 2014 23:13:52 -0400 Message-ID: <533E231C.3080400@linux.vnet.ibm.com> Date: Fri, 04 Apr 2014 11:12:28 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com> <531F82CA.8070905@redhat.com> In-Reply-To: <531F82CA.8070905@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, pbonzini@redhat.com, quintela@redhat.com, abali@us.ibm.com, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, hinesmr@cn.ibm.com, isaku.yamahata@gmail.com, gokul@us.ibm.com, dbulkow@gmail.com, junqing.wang@cs2c.com.cn, BIRAN@il.ibm.com, lig.fnst@cn.fujitsu.com, "Michael R. Hines" On 03/12/2014 05:40 AM, Eric Blake wrote: >> +++ b/qapi-schema.json >> @@ -169,6 +169,8 @@ >> # >> # @save-vm: guest is paused to save the VM state >> # >> +# @checkpoint-vm: guest is paused to checkpoint the VM state >> +# > It would be nice to mention '(since 2.1)'. Acknowledged. >> # @shutdown: guest is shut down (and -no-shutdown is in use) >> # >> # @suspended: guest is suspended (ACPI S3) >> @@ -181,7 +183,7 @@ >> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused', >> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm', >> 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog', >> - 'guest-panicked' ] } >> + 'guest-panicked', 'checkpoint-vm' ] } > It would also be nice to document the enum variables in the same order > you declare them. The declaration of 'checkpoint-vm' does not have to > be at the end; we use named enums precisely so that the QMP interface is > not tied to the C integer value underlying the enum. > Acknowledged. - Michael