From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVudA-00038W-FQ for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVud2-0004K4-Ke for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:17:24 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:46133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVud2-0004Ja-H2 for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:17:16 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Apr 2014 23:17:16 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id E3ABD38C804A for ; Thu, 3 Apr 2014 23:17:14 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22036.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s343HEpb4784520 for ; Fri, 4 Apr 2014 03:17:14 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s343HDdX019049 for ; Thu, 3 Apr 2014 23:17:14 -0400 Message-ID: <533E23E6.9090705@linux.vnet.ibm.com> Date: Fri, 04 Apr 2014 11:15:50 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-8-git-send-email-mrhines@linux.vnet.ibm.com> <531F83E3.5050803@redhat.com> In-Reply-To: <531F83E3.5050803@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 07/12] mc: introduce additional QMP statistics for micro-checkpointing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, pbonzini@redhat.com, quintela@redhat.com, abali@us.ibm.com, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, hinesmr@cn.ibm.com, isaku.yamahata@gmail.com, gokul@us.ibm.com, dbulkow@gmail.com, junqing.wang@cs2c.com.cn, BIRAN@il.ibm.com, lig.fnst@cn.fujitsu.com, "Michael R. Hines" On 03/12/2014 05:45 AM, Eric Blake wrote: >> +++ b/qapi-schema.json >> @@ -603,6 +603,36 @@ >> 'cache-miss': 'int', 'overflow': 'int' } } >> >> ## >> +# @MCStats >> +# >> +# Detailed Micro Checkpointing (MC) statistics >> +# >> +# @mbps: throughput of transmitting last MC >> +# >> +# @xmit-time: milliseconds to transmit last MC > Trailing whitespace. > > Rather than abbreviate, how about naming this 'transmit-time'. Acknowledged. >> +# >> +# @checkpoints: cummulative total number of MCs generated > More trailing whitespace. Please run your series through > scripts/checkpatch.pl. > > s/cummulative total/cumulative/ Acknowledged. >> +# >> +# Since: 2.x >> +## >> +{ 'type': 'MCStats', >> + 'data': {'mbps': 'number', >> + 'xmit-time': 'uint64', >> + 'log-dirty-time': 'uint64', >> + 'migration-bitmap-time': 'uint64', >> + 'ram-copy-time': 'uint64', >> + 'checkpoints' : 'uint64', >> + 'copy-mbps': 'number' }} > Again, it helps to document the fields in the same order as they are > declared (no, it's not a hard requirement, but being nice to readers is > always worth the effort). Acknowledged. >> + >> +## >> # @MigrationInfo >> # >> # Information about current migration process. >> @@ -624,6 +654,8 @@ >> # migration statistics, only returned if XBZRLE feature is on and >> # status is 'active' or 'completed' (since 1.2) >> # >> +# @mc: #options @MCStats containing details Micro-Checkpointing statistics > s/options/optional/ - I'm assuming it is optional because it only > appears when MC is in use. > > 'mc' is a rather short name, maybe 'micro-checkpoint' is better? Funny. I thought 'micro-checkpoint' was too long, particularly in the ./configure output and the QEMU Monitor 'help' command output =) > Missing a '(since 2.1)' designation (or 2.x, as you used above as a > placeholder, although obviously we'd fix the .x before actually bringing > into mainline) > Acknowledged. - Michael