From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVvH8-0007Sx-2a for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:58:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVvGz-0008I6-0O for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:58:41 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:37966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVvGy-0008Hy-Ou for qemu-devel@nongnu.org; Thu, 03 Apr 2014 23:58:32 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Apr 2014 21:58:32 -0600 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 3B4E138C8045 for ; Thu, 3 Apr 2014 23:58:29 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22035.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s343wTvt1245562 for ; Fri, 4 Apr 2014 03:58:29 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s343wSmo007846 for ; Thu, 3 Apr 2014 23:58:28 -0400 Message-ID: <533E2D90.5070106@linux.vnet.ibm.com> Date: Fri, 04 Apr 2014 11:57:04 +0800 From: "Michael R. Hines" MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-12-git-send-email-mrhines@linux.vnet.ibm.com> <87r468z94z.fsf@elfo.mitica> <531F8934.7080907@redhat.com> In-Reply-To: <531F8934.7080907@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 11/12] mc: introduce new capabilities to control micro-checkpointing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , quintela@redhat.com Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, pbonzini@redhat.com, abali@us.ibm.com, qemu-devel@nongnu.org, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, hinesmr@cn.ibm.com, isaku.yamahata@gmail.com, gokul@us.ibm.com, dbulkow@gmail.com, junqing.wang@cs2c.com.cn, BIRAN@il.ibm.com, lig.fnst@cn.fujitsu.com, "Michael R. Hines" On 03/12/2014 06:07 AM, Eric Blake wrote: > On 03/11/2014 04:02 PM, Juan Quintela wrote: >> mrhines@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> +# @mc-net-disable: Deactivate network buffering against outbound network >>> +# traffic while Micro-Checkpointing (@mc) is active. >>> +# Enabled by default. Disabling will make the MC protocol inconsistent >>> +# and potentially break network connections upon an actual failure. >>> +# Only for performance testing. (Since 2.x) >> If it is dangerous, can we put dangerous/unsafe on the name? Having an option that >> can corrupt things make me nervous. > Or even name it x-mc-net-disable, so that we reserve the right to remove > it, as well as make it obvious that management must not try to tune it, > only developers. > Good idea..... will do. - Michael