qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen.5i5j@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely
Date: Fri, 04 Apr 2014 17:39:33 +0800	[thread overview]
Message-ID: <533E7DD5.3090203@gmail.com> (raw)
In-Reply-To: <CAFEAcA9dk3991gc+FK0qp9QwhWkjxO0vK=X1TxS37Y1sXD5RNw@mail.gmail.com>

When you ask for an accelerator not supported for your target, you get
a bogus "accelerator does not exist" message:

  $ qemu-system-arm -machine none,accel=kvm
  KVM not supported for this target
  "kvm" accelerator does not exist.
  No accelerator found!

Suppress it.


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 vl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/vl.c b/vl.c
index 842e897..b4f98fa 100644
--- a/vl.c
+++ b/vl.c
@@ -2709,7 +2709,7 @@ static int configure_accelerator(QEMUMachine *machine)
                 if (!accel_list[i].available()) {
                     printf("%s not supported for this target\n",
                            accel_list[i].name);
-                    continue;
+                    break;
                 }
                 *(accel_list[i].allowed) = true;
                 ret = accel_list[i].init(machine);
-- 
1.7.9.5

  parent reply	other threads:[~2014-04-04  9:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  1:16 [Qemu-devel] [PATCH] vl.c: use 'break' instead of 'continue' in configure_accelerator() Chen Gang
2014-03-27  7:55 ` Marcel Apfelbaum
2014-03-27  9:54   ` Chen Gang
2014-03-27  8:59 ` Markus Armbruster
2014-03-27 10:01   ` Chen Gang
2014-03-30 14:44     ` Chen Gang
2014-03-31 12:38       ` Markus Armbruster
2014-03-31 12:53         ` Chen Gang
2014-03-31 13:01           ` Peter Maydell
2014-03-31 13:12             ` Chen Gang
2014-03-31 13:16               ` Peter Maydell
2014-03-31 13:26                 ` Chen Gang
2014-03-31 13:33                   ` Peter Maydell
2014-03-31 23:50                     ` Chen Gang
2014-04-04  9:39                     ` Chen Gang [this message]
2014-04-04 10:57                       ` [Qemu-devel] [PATCH-trivial v2] vl: Report accelerator not supported for target more nicely Markus Armbruster
2014-04-06 12:30                         ` Chen Gang
2014-04-06  6:32                       ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-04-06 12:32                         ` Chen Gang
2014-04-08 12:00                           ` [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device() Chen Gang
2014-04-08 12:01                             ` [Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue' Chen Gang
2014-04-08 12:02                               ` [Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res' Chen Gang
2014-04-08 12:05                                 ` [Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533E7DD5.3090203@gmail.com \
    --to=gang.chen.5i5j@gmail.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).