From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: aik@au1.ibm.com, qemu-devel@nongnu.org,
"Mark Wu" <wudxw@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
agraf@suse.com
Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults
Date: Fri, 04 Apr 2014 13:00:37 +0200 [thread overview]
Message-ID: <533E90D5.6040504@redhat.com> (raw)
In-Reply-To: <87mwg1wec2.fsf@blackfin.pond.sub.org>
Il 04/04/2014 12:58, Markus Armbruster ha scritto:
>>> >>
>>> >> Have you considered extending QEMUMachineInitArgs instead of adding this
>>> >> function?
>> >
>> > Did not think of this option earlier. You mean doing something like
>> > this?
> Yes. Looks nicer, doesn't it?
I still think it's a libvirt bug. Mixing -nodefaults and -usb and
-device is looking for trouble I think. "-usb" is a do-what-I-mean kind
of option and it makes sense for it to add a keyboard and mouse, even
with -nodefaults.
Paolo
next prev parent reply other threads:[~2014-04-04 11:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:56 [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults Nikunj A Dadhania
2014-04-03 17:01 ` Andreas Färber
2014-04-03 17:07 ` Nikunj A Dadhania
2014-04-03 17:06 ` Nikunj A Dadhania
2014-04-03 17:12 ` Andreas Färber
2014-04-04 6:34 ` Markus Armbruster
2014-04-04 8:28 ` Nikunj A Dadhania
2014-04-04 10:58 ` Markus Armbruster
2014-04-04 11:00 ` Paolo Bonzini [this message]
2014-04-04 11:23 ` Markus Armbruster
2014-04-04 15:08 ` Eric Blake
2014-04-04 13:14 ` Andreas Färber
2014-04-03 18:01 ` Paolo Bonzini
2014-04-03 18:32 ` Eric Blake
2014-04-03 19:24 ` Nikunj A Dadhania
2014-04-03 19:37 ` Paolo Bonzini
2014-04-04 5:28 ` Nikunj A Dadhania
2014-04-04 11:02 ` Paolo Bonzini
2014-04-04 11:40 ` Nikunj A Dadhania
2014-04-04 11:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533E90D5.6040504@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.com \
--cc=aik@au1.ibm.com \
--cc=armbru@redhat.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=wudxw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).