From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW1rv-0006HI-Tv for qemu-devel@nongnu.org; Fri, 04 Apr 2014 07:01:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW1rp-0006XM-OZ for qemu-devel@nongnu.org; Fri, 04 Apr 2014 07:01:07 -0400 Message-ID: <533E90D5.6040504@redhat.com> Date: Fri, 04 Apr 2014 13:00:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1396544174-8904-1-git-send-email-nikunj@linux.vnet.ibm.com> <871txez6jd.fsf@abhimanyu.in.ibm.com> <87d2gx4n88.fsf@blackfin.pond.sub.org> <877g758pnj.fsf@abhimanyu.in.ibm.com> <87mwg1wec2.fsf@blackfin.pond.sub.org> In-Reply-To: <87mwg1wec2.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Nikunj A Dadhania Cc: aik@au1.ibm.com, qemu-devel@nongnu.org, Mark Wu , qemu-ppc@nongnu.org, =?ISO-8859-15?Q?Andreas_F=E4rber?= , agraf@suse.com Il 04/04/2014 12:58, Markus Armbruster ha scritto: >>> >> >>> >> Have you considered extending QEMUMachineInitArgs instead of adding this >>> >> function? >> > >> > Did not think of this option earlier. You mean doing something like >> > this? > Yes. Looks nicer, doesn't it? I still think it's a libvirt bug. Mixing -nodefaults and -usb and -device is looking for trouble I think. "-usb" is a do-what-I-mean kind of option and it makes sense for it to add a keyboard and mouse, even with -nodefaults. Paolo