qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, agraf@suse.com
Cc: aik@au1.ibm.com, "Mark Wu" <wudxw@linux.vnet.ibm.com>,
	qemu-ppc@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults
Date: Fri, 04 Apr 2014 13:47:41 +0200	[thread overview]
Message-ID: <533E9BDD.9000302@redhat.com> (raw)
In-Reply-To: <874n298gro.fsf@abhimanyu.in.ibm.com>

Il 04/04/2014 13:40, Nikunj A Dadhania ha scritto:
>> > Sure.  However, I'm saying that it's fine for spapr to make -usb mean
>> > "OHCI, and also keyboard & mouse if there is a VGA card in the system".
>> >
>> > If libvirt used "-device pci-ohci" unconditionally, it would fix the bug
>> > *and* it would ensure that the PCI slot of pci-ohci does not change due
>> > to some other unrelated reason.  So I would rather have the fix in libvirt.
> Sure, let me check this.

It is probably not that easy---libvirt needs to have an implicit USB 
<controller> element in the domain XML or something like that, and let 
the user's XML override the default USB controller.  But it would be 
much better and much more consistent with x86.

Paolo

      reply	other threads:[~2014-04-04 11:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 16:56 [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults Nikunj A Dadhania
2014-04-03 17:01 ` Andreas Färber
2014-04-03 17:07   ` Nikunj A Dadhania
2014-04-03 17:06 ` Nikunj A Dadhania
2014-04-03 17:12   ` Andreas Färber
2014-04-04  6:34   ` Markus Armbruster
2014-04-04  8:28     ` Nikunj A Dadhania
2014-04-04 10:58       ` Markus Armbruster
2014-04-04 11:00         ` Paolo Bonzini
2014-04-04 11:23           ` Markus Armbruster
2014-04-04 15:08             ` Eric Blake
2014-04-04 13:14       ` Andreas Färber
2014-04-03 18:01 ` Paolo Bonzini
2014-04-03 18:32   ` Eric Blake
2014-04-03 19:24   ` Nikunj A Dadhania
2014-04-03 19:37     ` Paolo Bonzini
2014-04-04  5:28       ` Nikunj A Dadhania
2014-04-04 11:02         ` Paolo Bonzini
2014-04-04 11:40           ` Nikunj A Dadhania
2014-04-04 11:47             ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533E9BDD.9000302@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.com \
    --cc=aik@au1.ibm.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=wudxw@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).