* [Qemu-devel] [PATCH] spapr_nvram: Correct max nvram size
@ 2014-04-04 7:26 Alexey Kardashevskiy
2014-04-04 12:18 ` Alexander Graf
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2014-04-04 7:26 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, qemu-ppc, Alexander Graf, Thomas Huth
Currently it is UINT16_MAX*16 = 65536*16 = 1048560 which is not
a round number and therefore a bit confusing.
This defines MAX_NVRAM_SIZE precisely as 1MB.
Suggested-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
hw/nvram/spapr_nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvram/spapr_nvram.c b/hw/nvram/spapr_nvram.c
index 635713e..af49c46 100644
--- a/hw/nvram/spapr_nvram.c
+++ b/hw/nvram/spapr_nvram.c
@@ -42,7 +42,7 @@ typedef struct sPAPRNVRAM {
#define MIN_NVRAM_SIZE 8192
#define DEFAULT_NVRAM_SIZE 65536
-#define MAX_NVRAM_SIZE (UINT16_MAX * 16)
+#define MAX_NVRAM_SIZE 1048576
static void rtas_nvram_fetch(PowerPCCPU *cpu, sPAPREnvironment *spapr,
uint32_t token, uint32_t nargs,
--
1.8.4.rc4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr_nvram: Correct max nvram size
2014-04-04 7:26 [Qemu-devel] [PATCH] spapr_nvram: Correct max nvram size Alexey Kardashevskiy
@ 2014-04-04 12:18 ` Alexander Graf
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2014-04-04 12:18 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-ppc, qemu-devel, Thomas Huth
On 04/04/2014 09:26 AM, Alexey Kardashevskiy wrote:
> Currently it is UINT16_MAX*16 = 65536*16 = 1048560 which is not
> a round number and therefore a bit confusing.
>
> This defines MAX_NVRAM_SIZE precisely as 1MB.
>
> Suggested-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Thanks, applied to ppc-next-2.1.
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-04 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-04 7:26 [Qemu-devel] [PATCH] spapr_nvram: Correct max nvram size Alexey Kardashevskiy
2014-04-04 12:18 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).