From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WW3xY-0001cS-HF
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:15:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WW3xR-0007HY-2K
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:15:04 -0400
Message-ID: <533EB04E.4080205@suse.de>
Date: Fri, 04 Apr 2014 15:14:54 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1396544174-8904-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<871txez6jd.fsf@abhimanyu.in.ibm.com>
	<87d2gx4n88.fsf@blackfin.pond.sub.org>
	<877g758pnj.fsf@abhimanyu.in.ibm.com>
In-Reply-To: <877g758pnj.fsf@abhimanyu.in.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in
 case of -nodefaults
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: Alexander Graf <agraf@suse.de>, aik@au1.ibm.com, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Mark Wu <wudxw@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

Am 04.04.2014 10:28, schrieb Nikunj A Dadhania:
> diff --git a/vl.c b/vl.c
> index 017f92d..0d6c36c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4348,7 +4348,8 @@ int main(int argc, char **argv, char **envp)
>                                   .kernel_filename =3D kernel_filename,
>                                   .kernel_cmdline =3D kernel_cmdline,
>                                   .initrd_filename =3D initrd_filename,
> -                                 .cpu_model =3D cpu_model };
> +                                 .cpu_model =3D cpu_model,
> +                                 .has_defaults =3D has_defaults, };

If we do this, please put
       };
on the next line so that the next person appending something doesn't
need to touch it again. :)

I do agree with the others that libvirt shouldn't be using the legacy
-usb option.

Cheers,
Andreas

>      machine->init(&args);
> =20
>      audio_init();

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg