From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Don't parse 'filename' option
Date: Fri, 04 Apr 2014 15:45:12 +0200 [thread overview]
Message-ID: <533EB768.2010709@redhat.com> (raw)
In-Reply-To: <1396613033-20222-2-git-send-email-kwolf@redhat.com>
On 04.04.2014 14:03, Kevin Wolf wrote:
> When using the QDict option 'filename', it is supposed to be interpreted
> literally. The code did correctly avoid guessing the protocol from any
> string before the first colon, but it still called bdrv_parse_filename()
> which would, for example, incorrectly remove a 'file:' prefix in the
> raw-posix driver.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block.c | 8 ++++----
> tests/qemu-iotests/051 | 4 ++++
> tests/qemu-iotests/051.out | 11 +++++++++++
> 3 files changed, 19 insertions(+), 4 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-04-04 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 12:03 [Qemu-devel] [PATCH for-2.0 0/3] bdrv_open() fixes Kevin Wolf
2014-04-04 12:03 ` [Qemu-devel] [PATCH 1/3] block: Don't parse 'filename' option Kevin Wolf
2014-04-04 13:45 ` Max Reitz [this message]
2014-04-04 12:03 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Remove CR line endings in reference output Kevin Wolf
2014-04-04 13:47 ` Max Reitz
2014-04-04 12:03 ` [Qemu-devel] [PATCH 3/3] block: Fix snapshot=on for protocol parsed from filename Kevin Wolf
2014-04-04 14:38 ` Max Reitz
2014-04-04 15:04 ` Kevin Wolf
2014-04-04 14:56 ` [Qemu-devel] [PATCH v2 " Kevin Wolf
2014-04-04 15:23 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EB768.2010709@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).