From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW4Qv-00011p-8U
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:45:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW4Qp-0008PL-2T
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:45:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23167)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW4Qo-0008PF-Jv
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:45:18 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s34DjHRl007846
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 4 Apr 2014 09:45:18 -0400
Message-ID: <533EB768.2010709@redhat.com>
Date: Fri, 04 Apr 2014 15:45:12 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1396613033-20222-1-git-send-email-kwolf@redhat.com>
	<1396613033-20222-2-git-send-email-kwolf@redhat.com>
In-Reply-To: <1396613033-20222-2-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] block: Don't parse 'filename' option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com

On 04.04.2014 14:03, Kevin Wolf wrote:
> When using the QDict option 'filename', it is supposed to be interpreted
> literally. The code did correctly avoid guessing the protocol from any
> string before the first colon, but it still called bdrv_parse_filename()
> which would, for example, incorrectly remove a 'file:' prefix in the
> raw-posix driver.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block.c                    |  8 ++++----
>   tests/qemu-iotests/051     |  4 ++++
>   tests/qemu-iotests/051.out | 11 +++++++++++
>   3 files changed, 19 insertions(+), 4 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>