From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4Sx-0003w4-S6 for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW4Sr-0000bT-Np for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:47:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4Sr-0000bM-Fv for qemu-devel@nongnu.org; Fri, 04 Apr 2014 09:47:25 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s34DlOIi029686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Apr 2014 09:47:24 -0400 Message-ID: <533EB7E4.8020607@redhat.com> Date: Fri, 04 Apr 2014 15:47:16 +0200 From: Max Reitz MIME-Version: 1.0 References: <1396613033-20222-1-git-send-email-kwolf@redhat.com> <1396613033-20222-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1396613033-20222-3-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Remove CR line endings in reference output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 04.04.2014 14:03, Kevin Wolf wrote: > qemu doesn't print these CRs any more. The test still didn't fail > because the output comparison ignores line endings, but the change turns > up each time when you want to update the output. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/051.out | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) This patch doesn't work so well over email, but looking at 051.out itself, it seems correct. Reviewed-by: Max Reitz