From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4kj-0002pp-Pd for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW4kb-0006NX-3G for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:05:53 -0400 Received: from mail-qg0-x22d.google.com ([2607:f8b0:400d:c04::22d]:37715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW4ka-0006NJ-Np for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:05:45 -0400 Received: by mail-qg0-f45.google.com with SMTP id j5so3363165qga.18 for ; Fri, 04 Apr 2014 07:05:44 -0700 (PDT) Sender: Richard Henderson Message-ID: <533EBC32.4010404@twiddle.net> Date: Fri, 04 Apr 2014 07:05:38 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1396612363-13439-1-git-send-email-peter.maydell@linaro.org> <1396612363-13439-3-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1396612363-13439-3-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.0 v2 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Riku Voipio , "Andrei E. Warkentin" , patches@linaro.org On 04/04/2014 04:52 AM, Peter Maydell wrote: > If the guest attempts to execute from unreadable memory, this will > cause us to longjmp back to the main loop from inside the > target frontend decoder. For linux-user mode, this means we will > still hold the tb_ctx.tb_lock, and will deadlock when we try to > start executing code again. Unlock the lock in the return-from-longjmp > code path to avoid this. > > Signed-off-by: Peter Maydell > Acked-by: Andrei Warkentin Reviewed-by: Richard Henderson r~