From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW5L4-0005gc-AC
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:43:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW5Kx-0003sc-DE
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:43:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WW5Kx-0003sI-4s
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:43:19 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s34EhHRv015512
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 4 Apr 2014 10:43:18 -0400
Message-ID: <533EC4FE.1040609@redhat.com>
Date: Fri, 04 Apr 2014 16:43:10 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1396613969-22219-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1396613969-22219-1-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qcow2: Put cache reference in error case
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com

On 04.04.2014 14:19, Kevin Wolf wrote:
> When qcow2_get_cluster_offset() sees a zero cluster in a version 2
> image, it (rightfully) returns an error. But in doing so it shouldn't
> leak an L2 table cache reference.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   block/qcow2-cluster.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>