Re: [Qemu-devel] [PATCH] qga: trivial fix for unclear document of guest-set-time

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]

On 04/03/2014 06:53 PM, Amos Kong wrote:
> We mixedly used "guest time", "system time", "hardware time", "RTC"

s/mixedly used/mixed the use of/

> in document, it's unclear.

s/document/documentation/

> 
> This patch just added two remarks of RTC and replace two "guest time"
> by "guest's system time".
> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  qga/commands-posix.c |  2 +-
>  qga/qapi-schema.json | 14 +++++++-------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 6b5f11f..25e4302 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -171,7 +171,7 @@ void qmp_guest_set_time(bool has_time, int64_t time_ns, Error **errp)
>      /* Now, if user has passed a time to set and the system time is set, we
>       * just need to synchronize the hardware clock. However, if no time was
>       * passed, user is requesting the opposite: set the system time from the
> -     * hardware clock. */
> +     * hardware clock(RTC). */

s/clock(/clock (/

> -# This command tries to set guest time to the given value,
> -# then sets the Hardware Clock to the current System Time.
> -# This will make it easier for a guest to resynchronize
> -# without waiting for NTP. If no @time is specified, then
> -# the time to set is read from RTC.
> +# This command tries to set guest's System Time to the
> +# given value, then sets the Hardware Clock(RTC) to the

and again

With those changes,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]