From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW5jM-00028V-6Y for qemu-devel@nongnu.org; Fri, 04 Apr 2014 11:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW5jG-0004qD-Lg for qemu-devel@nongnu.org; Fri, 04 Apr 2014 11:08:32 -0400 Message-ID: <533ECAE3.8050407@redhat.com> Date: Fri, 04 Apr 2014 09:08:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396544174-8904-1-git-send-email-nikunj@linux.vnet.ibm.com> <871txez6jd.fsf@abhimanyu.in.ibm.com> <87d2gx4n88.fsf@blackfin.pond.sub.org> <877g758pnj.fsf@abhimanyu.in.ibm.com> <87mwg1wec2.fsf@blackfin.pond.sub.org> <533E90D5.6040504@redhat.com> <87mwg1uym0.fsf@blackfin.pond.sub.org> In-Reply-To: <87mwg1uym0.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JNST9FHKGtT1ABspJxqQ4aPvD09OhrgDJ" Subject: Re: [Qemu-devel] [PATCH] spapr: skip adding usb keyboard/mouse in case of -nodefaults List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Paolo Bonzini Cc: aik@au1.ibm.com, Nikunj A Dadhania , "libvir-list@redhat.com" , qemu-devel@nongnu.org, Mark Wu , qemu-ppc@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , agraf@suse.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JNST9FHKGtT1ABspJxqQ4aPvD09OhrgDJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable [adding libvir-list] On 04/04/2014 05:23 AM, Markus Armbruster wrote: > Paolo Bonzini writes: >=20 >> Il 04/04/2014 12:58, Markus Armbruster ha scritto: >>>>>>> >>>>>>> Have you considered extending QEMUMachineInitArgs instead of addi= ng this >>>>>>> function? >>>>> >>>>> Did not think of this option earlier. You mean doing something like= >>>>> this? >>> Yes. Looks nicer, doesn't it? >> >> I still think it's a libvirt bug. Mixing -nodefaults and -usb and >> -device is looking for trouble I think. "-usb" is a do-what-I-mean >> kind of option and it makes sense for it to add a keyboard and mouse, >> even with -nodefaults. >=20 > I agree that management tools should not use -usb, except when they wan= t > to manage ancient versions of QEMU for some reason. We've tried to make libvirt avoid -usb when it knows it is targetting a new enough qemu. But I'm not the one most familiar with that code. At this point, I'm just trying to facilitate discussions, and make sure the right people are looking at this - what versions of qemu vs. libvirt have you tested, and what does libvirt still need to patch to avoid -usb, and/or qemu patch so that libvirt can correctly probe that -usb is not needed? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JNST9FHKGtT1ABspJxqQ4aPvD09OhrgDJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTPsrjAAoJEKeha0olJ0NqmWoH/015qhaenVQFV8jP5uWb7ioo OoFPmhSWEVqAxtYONLGBdYiKdtvZIMX4EkSqHjVTsxv4Fog4PC120HYUyDi6Pqv9 eGKGOI9c0sRmeQU4XTSS9MaG7pGFwxG996e7PHlvyMpPeZn+b9yGqbAxtd1dBP4t yTKrmUYuFIDJXhUp1gSyCGUTGGrWLyyqb7LK6vfVX6xkeJkK0dUxRNgYx6YIDzvz iWp8+uEEVbn06xSE0tmEvTz4tJSAetuDwzq4xFzvwp/Dpz0iowM5cPde1zBIypHR azssyB6pDL/f1kEUevUDE4bGhKjXFvTyOHc7AAw3N7mi1SjNOvRcsmnufpR3NX8= =p9+v -----END PGP SIGNATURE----- --JNST9FHKGtT1ABspJxqQ4aPvD09OhrgDJ--