From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW7rQ-0001Jq-E2 for qemu-devel@nongnu.org; Fri, 04 Apr 2014 13:25:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW7rM-0003a1-1P for qemu-devel@nongnu.org; Fri, 04 Apr 2014 13:25:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW7rL-0003Zt-P0 for qemu-devel@nongnu.org; Fri, 04 Apr 2014 13:24:55 -0400 Message-ID: <533EEAE1.3040005@redhat.com> Date: Fri, 04 Apr 2014 11:24:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1396605482-8720-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1396605482-8720-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LV4lrkfNQSOvlTAmOFVtv7QKwXRTvw33l" Subject: [Qemu-devel] For 2.0? Re: [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , weidong.huang@huawei.com, quintela@redhat.com, dgilbert@redhat.com, owasserm@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LV4lrkfNQSOvlTAmOFVtv7QKwXRTvw33l Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/04/2014 03:57 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > V5-->V4 > * Fix two issues: one is cache_insert don't update the page which > has been in the cache. Another avoiding the risk that run > xbzrle_encode_buffer on changing data. Is all or part of this series essential to have in 2.0 to avoid having a regression? >=20 >=20 > a. Optimization the xbzrle remarkable decrease the cache misses. > The efficiency of compress increases more than fifty times. > Before the patch set, the cache almost totally miss when the > number of cache item less than the dirty page number. Now the > hot pages in the cache will not be replaced by other pages. >=20 > b. Reducing the data copy >=20 > c. Fix one corruption issues. >=20 > ChenLiang (10): > XBZRLE: Fix one XBZRLE corruption issues Based on name, this patch is worth including in the release, if it is not too late. > migration: Add counts of updating the dirty bitmap > migration: expose the bitmap_sync_count to the end user > migration: expose xbzrle cache miss rate whereas these names sound like new features, and thus should wait for 2.1= =2E > XBZRLE: optimize XBZRLE to decrease the cache misses > XBZRLE: rebuild the cache_is_cached function > xbzrle: don't check the value in the vm ram repeatedly > xbzrle: check 8 bytes at a time after an concurrency scene > migration: optimize xbzrle by reducing data copy > migration: clear the dead code >=20 > arch_init.c | 74 +++++++++++++++++------------- > docs/xbzrle.txt | 8 ++++ > hmp.c | 4 ++ > include/migration/migration.h | 2 + > include/migration/page_cache.h | 10 ++-- > migration.c | 3 ++ > page_cache.c | 101 +++++++++++----------------------= -------- > qapi-schema.json | 9 +++- > qmp-commands.hx | 15 ++++-- > xbzrle.c | 48 ++++++++++++++------ > 10 files changed, 144 insertions(+), 130 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LV4lrkfNQSOvlTAmOFVtv7QKwXRTvw33l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTPurhAAoJEKeha0olJ0NqdZ8H/joG8uaOA3iMEwkRKE86BBIr v6EamezTEwmAkE/iBDkWQ4BSPDtUJqG4x+NVgJ2tY5Sc/d4ccZUjdy2eUK4ZZVLL Ab7eiwDmcGtXPixr0F7HOk+2O3Mob4J3c4XtBgHaxn7+wFwDTVrZ4Ch8ankKKCHJ DoD79CX5UJXfyCHNhOQoHbt6HXTzdkGz5zl6miWoVt0Ky2is1V1+LA3zQm3VSxgg 5uZQ00vkJpuMB8RBFBdXekAtBuKO0TjtxEWSv1ceeHOTAVPv+ZoIkYCSfeuRid4p Ba301sfzp7p8YkzlhcSedzsF8ZRH3J0q+3x7uYedEQpBkE466GqQ1Peq8pdrHKM= =Npw3 -----END PGP SIGNATURE----- --LV4lrkfNQSOvlTAmOFVtv7QKwXRTvw33l--