From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] linux-user: remove useless variable
Date: Sun, 14 Jul 2019 18:02:59 +0200 [thread overview]
Message-ID: <533d36f2-b5a0-c89e-2a53-6fb8501caec4@redhat.com> (raw)
In-Reply-To: <20190714134028.315-1-laurent@vivier.eu>
On 7/14/19 3:40 PM, Laurent Vivier wrote:
> filename is only used to open the file if AT_EXECFD is not provided.
> But exec_path already contains the path of the file to open.
> Remove filename as it is only used in main.c whereas exec_path is
> also used in syscall.c.
>
> Fixes: d088d664f201 ("linux-user: identify running binary in /proc/self/exe")
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> linux-user/main.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index a59ae9439de1..ef8e8cb10eba 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -48,7 +48,6 @@
> char *exec_path;
>
> int singlestep;
> -static const char *filename;
> static const char *argv0;
> static int gdbstub_port;
> static envlist_t *envlist;
> @@ -580,7 +579,6 @@ static int parse_args(int argc, char **argv)
> exit(EXIT_FAILURE);
> }
>
> - filename = argv[optind];
> exec_path = argv[optind];
>
> return optind;
> @@ -651,9 +649,9 @@ int main(int argc, char **argv, char **envp)
>
> execfd = qemu_getauxval(AT_EXECFD);
> if (execfd == 0) {
> - execfd = open(filename, O_RDONLY);
> + execfd = open(exec_path, O_RDONLY);
> if (execfd < 0) {
> - printf("Error while loading %s: %s\n", filename, strerror(errno));
> + printf("Error while loading %s: %s\n", exec_path, strerror(errno));
> _exit(EXIT_FAILURE);
> }
> }
> @@ -778,10 +776,10 @@ int main(int argc, char **argv, char **envp)
> cpu->opaque = ts;
> task_settid(ts);
>
> - ret = loader_exec(execfd, filename, target_argv, target_environ, regs,
> + ret = loader_exec(execfd, exec_path, target_argv, target_environ, regs,
> info, &bprm);
> if (ret != 0) {
> - printf("Error while loading %s: %s\n", filename, strerror(-ret));
> + printf("Error while loading %s: %s\n", exec_path, strerror(-ret));
> _exit(EXIT_FAILURE);
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-14 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 13:40 [Qemu-devel] [PATCH 1/2] linux-user: remove useless variable Laurent Vivier
2019-07-14 13:40 ` [Qemu-devel] [PATCH 2/2] linux-user: manage binfmt-misc preserve-arg[0] flag Laurent Vivier
2019-07-14 16:19 ` John Paul Adrian Glaubitz
2019-07-17 10:07 ` Laurent Vivier
2019-07-30 11:04 ` John Paul Adrian Glaubitz
2019-07-30 11:25 ` Peter Maydell
2019-07-14 16:02 ` Philippe Mathieu-Daudé [this message]
2019-08-23 15:31 ` [Qemu-devel] [PATCH 1/2] linux-user: remove useless variable Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533d36f2-b5a0-c89e-2a53-6fb8501caec4@redhat.com \
--to=philmd@redhat.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).