From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXCUF-0000vw-7G for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:33:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXCU6-0007Bx-7y for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:33:31 -0400 Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:40196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXCU6-0007Br-3N for qemu-devel@nongnu.org; Mon, 07 Apr 2014 12:33:22 -0400 Received: by mail-qc0-f169.google.com with SMTP id i17so6754301qcy.28 for ; Mon, 07 Apr 2014 09:33:21 -0700 (PDT) Sender: Richard Henderson Message-ID: <5342D34C.4030604@twiddle.net> Date: Mon, 07 Apr 2014 09:33:16 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1396555000-8205-1-git-send-email-rth@twiddle.net> <1396555000-8205-2-git-send-email-rth@twiddle.net> <53425A88.2050806@huawei.com> In-Reply-To: <53425A88.2050806@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 01/26] tcg-aarch64: Properly detect SIGSEGV writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana , qemu-devel@nongnu.org Cc: Peter Maydell , claudio.fontana@gmail.com On 04/07/2014 12:58 AM, Claudio Fontana wrote: >> + || (insn & 0x3bc00000) == 0x28400000 /* C3.3.7 */ > > I think the Load (L) bit should be 0 here so > > == 0x28000000 Oops. Fixed. > >> + || (insn & 0x3be00c00) == 0x38000400 /* C3.3.8 */ > > With V=1, an opc of 0b10 is also a write, I think. It's the 128bit FP/SIMD STR. Exactly, that's why I'm masking it out, to ignore it. insn = size 1 1 1 v 0 0 ... mask = 0 0 1 1 1 0 1 1 ... = 0x3b... equal = 0 0 1 1 1 0 0 0 ... = 0x38... r~