qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tom Musta <tommusta@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode
Date: Mon, 07 Apr 2014 11:48:09 -0500	[thread overview]
Message-ID: <5342D6C9.7090308@gmail.com> (raw)
In-Reply-To: <CAFEAcA-d370B+2YHUF2BuZ29J6gusYK-UD=suVmzvDoLvqR5VA@mail.gmail.com>

On 4/7/2014 10:00 AM, Peter Maydell wrote:
> It seems a touch dubious to assume the area of memory
> being dissassembled is necessarily the same endianness
> the CPU happens to be currently...

I don't disagree but it is less dubious than relying on TARGET_WORDS_BIGENDIAN,
which is what the code currently does.

I think the only other alternative is to put it back on the user via options
on the command, e.g.

  xp/8il
  xp/8ib

But, I would contend that the using the MSR[LE] bit would still be a better
default than TARGET_WORDS_BIGENDIAN if an option is not specified.

Thanks for the other comments ... I will incorporate.

      reply	other threads:[~2014-04-07 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 14:50 [Qemu-devel] [PATCH] monitor: QEMU Monitor Instruction Disassembly Incorrect for PowerPC LE Mode Tom Musta
2014-04-07 15:00 ` Peter Maydell
2014-04-07 16:48   ` Tom Musta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5342D6C9.7090308@gmail.com \
    --to=tommusta@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).